Add files via upload #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how to do pull requests and stuff but I've modified the file to address a few key issues. First, it now adds the author display name to files when an author is selected, and allows you to download more than one author (it skips the duplicate folder check, but still checks for filename duplicates). I removed a category check that limited the packs that were found. I also added some better error handling for the reported cases where things don't work. It still won't download them, but it will keep looking for other packs. By default I've also set duration to be a list of all possible durations but I think it will still function as previous if you manually use a fixed duration argument. There were also some packs that had problematic filenames (at least for windows) so I added a sanitize_filename code as well to strip things like colons and question marks.
|
yay filename sanitatizion sounds awesome. Then things as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the file to address a few key issues. It now adds the author display name to files when an author is selected using the --author argument. I removed the duplicate folder check UNLESS an author is not specified (it still checks duplicate filenames). I removed a category check that limited the packs that were found, expanding the scope of the downloadable packs. I also added some better error handling for the reported cases where things don't work. It still won't download them, but it will keep looking for other packs instead of quitting. By default I've also set duration to be a list of 1 to 30 mins but I it will still function as previous if you manually use a fixed duration argument. There were also some packs that had problematic filenames (at least for windows) so I added a sanitize_filename code as well to strip things like colons and question marks.